Support features in webxr #21159
Merged
Support features in webxr #21159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wpt-pr-bot
approved these changes
Jan 14, 2020
Manishearth
changed the title
|
cc @alcooper91 |
servo-wpt-sync
changed the title
servo-wpt-sync
changed the title
servo-wpt-sync
force-pushed
the
servo_export_25504
branch
from
d9154da
to
9d8fd55
Compare
Manishearth
changed the title
alcooper91
reviewed
Jan 14, 2020
| @@ -31,34 +31,27 @@ | |||
| } | |||
|
|
|||
| return navigator.xr.test.simulateDeviceConnection(fakeDeviceInitParams) | |||
| .then((controller) => new Promise((resolve, reject) => { | |||
| navigator.xr.test.simulateUserActivation(() => { | |||
| .then((controller) => navigator.xr.test.simulateUserActivation(() => | |||
There was a problem hiding this comment.
This last part here shouldn't be needed should it? You can just directly do the new method?
servo-wpt-sync
changed the title
servo-wpt-sync
force-pushed
the
servo_export_25504
branch
4 times, most recently
from
458770b
to
5c4b0c3
Compare
…or each session request
servo-wpt-sync
force-pushed
the
servo_export_25504
branch
from
5c4b0c3
to
62156e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed in servo/servo#25504.