Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rivet: fix patch url #77595

Merged
merged 1 commit into from Jan 13, 2020
Merged

rivet: fix patch url #77595

merged 1 commit into from Jan 13, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 13, 2020

Motivation for this change

The old url is now broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
rivet: fix patch url
592e750 
The old url is now broken. The new patch uses the new git repository.
@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 13, 2020
@veprbl
Copy link
Member Author

veprbl commented Jan 13, 2020

@GrahamcOfBorg build rivet

1 similar comment
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2020

@GrahamcOfBorg build rivet

@Mic92 Mic92 merged commit bf91434 into NixOS:master Jan 13, 2020
@Mic92
Copy link
Member

Mic92 commented Jan 13, 2020

backport: eb65d1d

@veprbl veprbl added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 19, 2020
@veprbl veprbl deleted the pr/rivet_patch_url_fix branch December 1, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @Mic92