Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xandikos: add tests and module #76178

Merged
merged 2 commits into from
Jan 13, 2020
Merged

xandikos: add tests and module #76178

merged 2 commits into from
Jan 13, 2020
+220 −0

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 22, 2019

Motivation for this change

Add tests and module for xandikos, which is included in #75532.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthiasbeyer

Sorry, something went wrong.

@0x4A6F 0x4A6F requested a review from infinisil as a code owner December 22, 2019 16:39
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 22, 2019
@0x4A6F
Copy link
Member Author

0x4A6F commented Dec 22, 2019

@GrahamcOfBorg test xandikos

1 similar comment
@Ma27
Copy link
Member

Ma27 commented Dec 22, 2019

@GrahamcOfBorg test xandikos

Ma27
Ma27 reviewed Dec 22, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks overall fine, thanks a lot!
Just a thought about the test: do we really need all of those VMs? I'm wondering as this means that you need notably more resources to execute the test-cases (although I'm not sure if we have some kind of "hard-limit" for tests, so feel free to disagree :D)

infinisil
infinisil requested changes Jan 7, 2020
View reviewed changes
@0x4A6F
Copy link
Member Author

0x4A6F commented Jan 8, 2020

I've reduced the vm-count on nixos test.
But at least I'd like to cover the main two use-cases (standalone and behind proxy).

If there is no more improvements, I'd like to rebase commits.

Thanks for the reviews.

aanderse
aanderse reviewed Jan 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Ma27 @infinisil any outstanding issues either of you see?

@infinisil infinisil changed the title xandikos: add tests and module Merge pull request #76178 from 0x4A6F/master-xandikos Jan 13, 2020
@infinisil infinisil merged commit 55b0129 into NixOS:master Jan 13, 2020
@0x4A6F 0x4A6F deleted the master-xandikos branch January 14, 2020 15:25
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
@infinisil @dtzWill
Merge pull request NixOS#76178 from 0x4A6F/master-xandikos

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
29184f9 
xandikos: add tests and module
(cherry picked from commit 55b0129)
@0x4A6F 0x4A6F changed the title Merge pull request #76178 from 0x4A6F/master-xandikos xandikos: add tests and module May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27

@aanderse aanderse

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@0x4A6F @Ma27 @aanderse @infinisil