Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-lens: () -> 1.2.3 #77656

Merged
merged 2 commits into from Jan 14, 2020
Merged

ocaml-lens: () -> 1.2.3 #77656

merged 2 commits into from Jan 14, 2020

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Jan 14, 2020

Motivation for this change

Package an OPAM module.

Things done

Tested with ocamlPackages_latest; the OPAM file says it works with 4.04.1+ so I put that as minimum version.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [N/A] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [N/A] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Jan 14, 2020

@GrahamcOfBorg build ocamlPackages.lens

@vbgl vbgl merged commit 69aa28a into NixOS:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants