SharedArrayBuffer and blob:/data: worker #21146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
zcorpan and
zqzhang
|
The problem with the data URL case is that it needs to use a blob URL for its nested worker as otherwise the nested worker would not be same-origin with it. (See also whatwg/html#5254 for how it's a bit more complex therefore.) |
|
That's now addressed. @hemeryar @ParisMeuleman @camillelamy please review! |
|
If this seems reasonable I could maybe make this more generic to also test blob/data frames this way. |
ParisMeuleman
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Thanks @annevk for this.
Overall lgtm.
Although adding a few comments, especially in the dataWorkerScript could improve readability IMO (e.g. view was not a very clear name to me, likewise for L52 the handling of the 2 messages from the sub-worker) .
I reckon doing the work to make it generic could solve this point.
annevk
added a commit
that referenced
this pull request
Feb 13, 2020
See w3c/webappsec-secure-contexts#69. Complements #21146.
|
@ParisMeuleman do you want to have another look? |
annevk
added a commit
to w3c/webappsec-secure-contexts
that referenced
this pull request
Feb 13, 2020
As long as they have a creator, anyway. (Note that data: URLs cannot be opened in a top-level browsing context, such as a popup, except via a user-initiated navigation.) Tests: web-platform-tests/wpt#21146 and web-platform-tests/wpt#21781. Fixes #69. Nice!
annevk
added a commit
that referenced
this pull request
Feb 13, 2020
See w3c/webappsec-secure-contexts#69. Complements #21146.
mikewest
pushed a commit
to w3c/webappsec-secure-contexts
that referenced
this pull request
Feb 13, 2020
As long as they have a creator, anyway. (Note that data: URLs cannot be opened in a top-level browsing context, such as a popup, except via a user-initiated navigation.) Tests: web-platform-tests/wpt#21146 and web-platform-tests/wpt#21781. Fixes #69. Nice!
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 17, 2020
Automatic update from web-platform-tests Secure contexts: add data: URLs See w3c/webappsec-secure-contexts#69. Complements web-platform-tests/wpt#21146. -- wpt-commits: cc7860faa93b6c404a5767b7635843d274eb7d0a wpt-pr: 21781
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Feb 18, 2020
Automatic update from web-platform-tests Secure contexts: add data: URLs See w3c/webappsec-secure-contexts#69. Complements web-platform-tests/wpt#21146. -- wpt-commits: cc7860faa93b6c404a5767b7635843d274eb7d0a wpt-pr: 21781
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Feb 18, 2020
Automatic update from web-platform-tests Secure contexts: add data: URLs See w3c/webappsec-secure-contexts#69. Complements web-platform-tests/wpt#21146. -- wpt-commits: cc7860faa93b6c404a5767b7635843d274eb7d0a wpt-pr: 21781 UltraBlame original commit: 9168eaebb7a09addc3a9c1700a2b2312bae790c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Feb 18, 2020
Automatic update from web-platform-tests Secure contexts: add data: URLs See w3c/webappsec-secure-contexts#69. Complements web-platform-tests/wpt#21146. -- wpt-commits: cc7860faa93b6c404a5767b7635843d274eb7d0a wpt-pr: 21781 UltraBlame original commit: 9168eaebb7a09addc3a9c1700a2b2312bae790c5
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 18, 2020
Automatic update from web-platform-tests Secure contexts: add data: URLs See w3c/webappsec-secure-contexts#69. Complements web-platform-tests/wpt#21146. -- wpt-commits: cc7860faa93b6c404a5767b7635843d274eb7d0a wpt-pr: 21781 UltraBlame original commit: 9168eaebb7a09addc3a9c1700a2b2312bae790c5
|
@ParisMeuleman ping. |
annevk
added a commit
that referenced
this pull request
Apr 14, 2020
#21146 missed a crucial aspect and could use slightly better variable naming. As the data URL document is (always) cross-origin from the testharness.js resource that resource needs the CORP header with cross-origin as value.
annevk
added a commit
that referenced
this pull request
Apr 14, 2020
PR #21146 missed a crucial aspect and could use slightly better variable naming. As the data URL document is (always) cross-origin from the testharness.js resource that resource needs the CORP header with cross-origin as value.
stephenmcgruer
pushed a commit
that referenced
this pull request
Apr 14, 2020
PR #21146 missed a crucial aspect and could use slightly better variable naming. As the data URL document is (always) cross-origin from the testharness.js resource that resource needs the CORP header with cross-origin as value.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Apr 21, 2020
Tests: * There should be a test for this where you create a data URL worker and try to message it SAB and WebAssembly.Module and check that it results in messageerror events. * web-platform-tests/wpt#21146 and web-platform-tests/wpt#22928 test that inside a data URL worker you can share memory with a further nested data URL worker that is same-origin with the opaque origin of the data URL worker. Fixes #5254.
3 tasks
annevk
added a commit
to whatwg/html
that referenced
this pull request
Mar 11, 2023
Tests: * There should be a test for this where you create a data URL worker and try to message it SAB and WebAssembly.Module and check that it results in messageerror events. * web-platform-tests/wpt#21146 and web-platform-tests/wpt#22928 test that inside a data URL worker you can share memory with a further nested data URL worker that is same-origin with the opaque origin of the data URL worker. Fixes #5254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#5198 and whatwg/html#4916.
blob:has to work, not sure aboutdata:URLs again.