Skip to content

python3.pkgs.publicsuffix: fix build #77613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2020
Merged

python3.pkgs.publicsuffix: fix build #77613

merged 2 commits into from
Jan 13, 2020
+1 −4

Conversation

alyssais
Copy link
Member

Motivation for this change

This patch has not been necessary since
5425867, and has in fact broken the
build since then.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@alyssais alyssais requested a review from FRidh January 13, 2020 12:27
@alyssais alyssais requested a review from jonringer as a code owner January 13, 2020 12:27
@alyssais
python3.pkgs.publicsuffix: fix build

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ondrejmirtes Ondřej Mirtes
GPG key ID: CF1A108D0E7AE720
Expired
Verified
Learn about vigilant mode
dd8bdee 
This patch has not been necessary since
5425867, and has in fact broken the
build since then.
@alyssais
python3.pkgs.publicsuffix: patchPhase -> postPatch

Verified

This commit was signed with the committer’s verified signature. The key has expired.
ondrejmirtes Ondřej Mirtes
GPG key ID: CF1A108D0E7AE720
Expired
Verified
Learn about vigilant mode
918c650
jonringer
jonringer approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[4 built, 1 copied (0.1 MiB), 0.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77613
3 package built:
python27Packages.publicsuffix python37Packages.publicsuffix python38Packages.publicsuffix

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.publicsuffix python37Packages.publicsuffix python38Packages.publicsuffix

@jonringer jonringer merged commit d184039 into NixOS:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alyssais @jonringer @FRidh