Skip to content

marktext: init #77694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

marktext: init #77694

merged 1 commit into from
Jan 15, 2020
+37 −0

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jan 14, 2020

Motivation for this change

https://marktext.app is a great editor.

Long-term it would be great to package it without using the AppImage binary release (see marktext/marktext#1647), but until that's done, this is a workaround.

I used the notable package by @dtzWill as a template. It is also an AppImage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@nh2 nh2 requested a review from dtzWill January 14, 2020 19:18
@nh2 nh2 self-assigned this Jan 14, 2020
@nh2 nh2 mentioned this pull request Jan 14, 2020
Open
@nh2
marktext: init at v0.16.0-rc.2
5cafbb1 
This uses the .AppImage binary release, until we have a real source package
(see marktext/marktext#1647).

I used the `notable` package as a template.
@nh2 nh2 force-pushed the marktext-appimage branch from 3ea0b08 to 5cafbb1 Compare January 14, 2020 19:23
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 14, 2020
@dtzWill
Copy link
Member

dtzWill commented Jan 14, 2020

LGTM! It'd be best to not package an -rc2 release, but personally I'd rather have it that way than not at all :). Any idea if there is likely a new stable release soon?

@nh2
Copy link
Contributor Author

nh2 commented Jan 15, 2020

It'd be best to not package an -rc2 release, but personally I'd rather have it that way than not at all :). Any idea if there is likely a new stable release soon?

I agree in principle but the RC2 fixes some issues that make using the app a big pain to use (https://github.com/marktext/marktext/releases/tag/v0.16.0-rc.2), so I've packaged (and tested) this as the first version that's useful to me.

I'll upgrade it once the non-RC 0.16.0 is out.

@dtzWill
Copy link
Member

dtzWill commented Jan 15, 2020 via email

@nh2 nh2 merged commit 81c2cc9 into NixOS:master Jan 15, 2020
@nh2 nh2 mentioned this pull request Mar 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill

Assignees

@nh2 nh2

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @dtzWill