Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gobetween: init at 0.7.0 #77597

Merged
merged 1 commit into from Jan 28, 2020
Merged

gobetween: init at 0.7.0 #77597

merged 1 commit into from Jan 28, 2020

Conversation

tomberek
Copy link
Contributor

Motivation for this change

Include a dynamic proxy into nixpkgs.

Things done

Build with buildGo112Module due to errors with go 1.13 (upstream is aware, issues filed).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Jan 13, 2020
View reviewed changes
pkgs/servers/gobetween/default.nix Outdated Show resolved Hide resolved
pkgs/servers/gobetween/default.nix
rev = "7d8a7368a535641df273c6b962750c1113d0c6b0";
sha256 = "628e9a3f37aa12f3c54ef7b81a707ea732179a0aa7bb621b8cd833535f27546e";
};
modSha256 =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be one line, and please put a space between that and src

Suggested change
modSha256 =
modSha256 =

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added space. long line is split by nixfmt, it does look odd, but i'm trying to apply nixfmt as much as possible. I can change if it's a problem.

@tomberek tomberek force-pushed the tomberek/gobetween branch 2 times, most recently from 2dcb4f5 to 62e5d66 Compare January 13, 2020 13:12
jonringer
jonringer reviewed Jan 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do notice that the version is wrong, not sure if there's an easy way to fix this:

$ ./results/gobetween/bin/gobetween --help
gobetween v0.8.0+snapshot
Modern & minimalistic load balancer for the Cloud era

@tomberek
Copy link
Contributor Author

Not sure about that. Seems like that’s an upstream tagging error. I can fish around for a more internally consistent commit, or bother upstream to tag 0.8.0.

@ofborg ofborg bot requested a review from kalbasit January 14, 2020 04:07
@jonringer
Copy link
Contributor

looks like there's sha mismatch https://github.com/NixOS/nixpkgs/pull/77597/checks?check_run_id=388386660

jonringer
jonringer reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM, but commits needs to be squashed https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

git reset HEAD^
git add pkgs/
git commit --amend --no-edit

@tomberek
Copy link
Contributor Author

Squashed. Thanks for the assist.

@ofborg ofborg bot requested a review from kalbasit January 18, 2020 04:07
@jonringer
Copy link
Contributor

@GrahamcOfBorg build gobetween

jonringer
jonringer approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll merge in a day if @kalbasit doesn't have any issues

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/109

@marsam marsam merged commit de6df13 into NixOS:master Jan 28, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@marsam @anna328p
Merge pull request NixOS#77597 from tomberek/tomberek/gobetween
a24a8e3 
gobetween: init at 0.7.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomberek @jonringer @nixos-discourse @kalbasit @marsam