Enforce strict_equality in mypy #21169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(this found bugs on manifest-path-trie)
gsnedders
commented
Jan 14, 2020
| @@ -269,7 +269,7 @@ def filter(self, | |||
| target.append(item) | |||
|
|
|||
| dirnames[:] = keep_dirs | |||
| assert ".git" not in dirnames | |||
| assert not any(".git" == name for name, _ in dirnames) | |||
There was a problem hiding this comment.
This assert has been guaranteed to never fail since 4011c5f due to asserting str in List[Tuple[str, T]], which always returns False.
jgraham
approved these changes
Jan 14, 2020
|
CI failure is #21158 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this found more bugs on manifest-path-trie)