Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.8.2 -> 0.8.3 #77652

Closed
wants to merge 1 commit into from
Closed

zfs: 0.8.2 -> 0.8.3 #77652

wants to merge 1 commit into from

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

Just trying the patchset that may become zfs 0.8.3 (see openzfs/zfs#9776)

Since there was a minor change in our derivation, I figured I'd send the change up.
For the moment, do not merge, this is beyond unstable :D

I am running this right now with kernel 4.19.95-hardened and things seem smooth.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@NeQuissimus
Copy link
Member Author

I believe this needs more work for 5.x kernels. I have not had a chance to try that.

@NeQuissimus
Copy link
Member Author

NeQuissimus commented Jan 18, 2020 •
edited

Updated the changes to work with kernel 5.4.11-hardened
openzfs/zfs#9089 has a change that bends a systemd unit to /dev/null/ but something else in the build tried to run sed -i against that, which fails.
It sounds like the change is Debian-specific, so I am partially reverting that particular diff.

Edit: Confirmed working with 4.19.95-hardened as well. Now my poor m3 laptop CPU is done building kernels :D

@NeQuissimus
Copy link
Member Author

The biggest thing here is that the ZFS-native encryption now uses hardware instructions. My SSD is finally reading faster than 20 MB/s again :D

@NeQuissimus NeQuissimus changed the title [DO NOT MERGE] zfs: Unstable 0.8.3 patchset zfs: 0.8.2 -> 0.8.3 Jan 24, 2020
@NeQuissimus
Copy link
Member Author

Updated to use the actual 0.8.3 tag that was just released.
I built my NixOS config with this and here I am, so things seem to work :D

@balsoft balsoft mentioned this pull request Jan 24, 2020
Merged
10 tasks
@wizeman
Copy link
Member

wizeman commented Jan 24, 2020

Looks good to me, but can you take a look at #78415?
We might want these two PRs to be merged together into one, as each one of them seems to have fixes the other doesn't.

@NeQuissimus
Copy link
Member Author

I think that PR may actually be a cleaner way of resolving the issues I've seen. Let's move the discussion there.

@NeQuissimus NeQuissimus deleted the zfs083 branch February 14, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@wizeman wizeman Awaiting requested review from wizeman

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NeQuissimus @wizeman