Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird rendering of solid difference #540

Closed
baryluk opened this issue Jan 13, 2020 · 7 comments · Fixed by #733
Closed

Weird rendering of solid difference #540

baryluk opened this issue Jan 13, 2020 · 7 comments · Fixed by #733

Comments

@baryluk
Copy link

baryluk commented Jan 13, 2020

System information

Compiled at commit 16c5fa6

Operating system: Debian testing, amd64

Expected behavior

What should have happened?

I had a lathe operation, plus 2 extra extrusions (one with 3x time rotating symmetry) acting as a difference.

At the end I wanted to see a crossection, so I did another sketch, extruded it, and used as a difference.

I expected to have a solid model, not hollow one, with some red marks on the edges. There are some other red marks, that I don't know what they are, and some edges (45 deg ones) do not have the red edges.

No idea what is going on.

Actual behavior

adapter-plate-section-4

adpate-plate-section-iso

Project file: adapter-plate.tar.gz

@baryluk
Copy link
Author

baryluk commented Jan 13, 2020

I just tried using phkahler:nurbs branch, and result is the same or even worse:

adpate-plate-section-2

adapter-plate-section-issue

@whitequark
Copy link
Contributor

Classic NURBS issue. Force triangle mesh for now.

@baryluk
Copy link
Author

baryluk commented Jan 13, 2020

@whitequark Indeed that helped:

adapter-plate-g00b-extrude-force-triangle-mesh

How will that affect STEP 3D export?

@whitequark
Copy link
Contributor

You wouldn't be able to export rational surfaces after this, only triangle meshes; in particular IIRC exported STEP files will just be empty and you'll have to use STL.

@baryluk
Copy link
Author

baryluk commented Jan 13, 2020

@whitequark That sucks. :/ What if I keep the model with this red things / errors and export then to STEP? Is the red thing due to rendering issue, or the model itself is broken due to intersection problems?

@whitequark
Copy link
Contributor

The model itself is broken. If you really need NURBS surfaces, try making the intersection not "cut across the seam". E.g. if you have a difference cutting exactly 1/4 of a circle, try moving it away by 0.1 mm or something.

@baryluk
Copy link
Author

baryluk commented Jan 13, 2020

@whitequark Thanks a lot.

phkahler added a commit to phkahler/solvespace that referenced this issue Oct 10, 2020
When a plane coinsides with a seam we need to copy that trim curve. The existing curve belongs to the original shell surfaces and an intersection is otherwise not found. Fixes solvespace#540.
phkahler added a commit that referenced this issue Oct 10, 2020
When a plane coinsides with a seam we need to copy that trim curve. The existing curve belongs to the original shell surfaces and an intersection is otherwise not found. Fixes #540.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants