[Gecko Bug 1599206] Don't serialize implicit tracks for grid-template properties, as they make the computed style not round-trip. #21147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… make the computed style not round-trip. Do this only on nightly for now since we're about to enter the soft freeze. (No test updates yet, as try is still running, and I need to figure out how to import Oriol's changes into WPT, but I wanted to ensure that you were fine with this) Differential Revision: https://phabricator.services.mozilla.com/D54595 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1599206 gecko-commit: 7de69291913b3fafe48f776fa1b6669e54d270a9 gecko-integration-branch: autoland gecko-reviewers: mats
wpt-pr-bot
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this only on nightly for now since we're about to enter the soft freeze.
(No test updates yet, as try is still running, and I need to figure out how to
import Oriol's changes into WPT, but I wanted to ensure that you were fine with
this)
Differential Revision: https://phabricator.services.mozilla.com/D54595
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1599206
gecko-commit: 7de69291913b3fafe48f776fa1b6669e54d270a9
gecko-integration-branch: autoland
gecko-reviewers: mats