Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samtools: 1.9 -> 1.10 #77654

Merged
merged 1 commit into from Jan 19, 2020
Merged

samtools: 1.9 -> 1.10 #77654

merged 1 commit into from Jan 19, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 14, 2020 •
edited

Motivation for this change

noticed it was broken on hydra: https://hydra.nixos.org/build/110280868

bumping seems to fix build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

looks like it breaks everything though:

[0 built (3 failed), 92 copied (638.4 MiB), 173.5 MiB DL]
error: build of '/nix/store/2n026f74l05x27nwhjz8f7n7jhbdrjn6-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77654
12 package failed to build:
deeptools python27Packages.HTSeq python27Packages.cnvkit python27Packages.pysam python37Packages.HTSeq python37Packages.cnvkit python37Packages.pysam python38Packages.HTSeq python38Packages.cnvkit python38Packages.pysam tebreak truvari

1 package were built:
samtools

@ofborg ofborg bot requested a review from mimame January 14, 2020 08:10
mimame
mimame approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@mimame mimame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the patch @jonringer

@jonringer
Copy link
Contributor Author

all these packages are broken on master anyway, as they directly rely on sam-tools, merging

@jonringer jonringer merged commit 4de137a into NixOS:master Jan 19, 2020
@jonringer jonringer deleted the bump-samtools branch January 19, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimame mimame mimame approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mimame