python3Packages.srsly: 0.2.0 -> 1.0.1 #77600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srsly 2.0.0 is also released. But since spaCy/textacy are the only dependencies and spaCy requires < 1.1.0, it probably makes more sense to bump this to 1.0.1 for the time being. And additional argument in favor of 1.0.1 is that 2.0.0 drops support for Python 3.5.
jonringer
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
LGTM
python38 failures unrelated to PR
[9 built (1 failed), 43 copied (84.2 MiB), 21.0 MiB DL]
error: build of '/nix/store/9fsgvhablls8vrkzzpmzhjsmm2jbymbf-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77600
2 package failed to build:
python38Packages.spacy python38Packages.textacy
8 package built:
python27Packages.srsly python27Packages.thinc python37Packages.spacy python37Packages.srsly python37Packages.textacy python37Packages.thinc python38Packages.srsly python38Packages.thinc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
srsly 2.0.0 is also released. But since spaCy/textacy are the only
dependencies and spaCy requires < 1.1.0, it probably makes more sense
to bump this to 1.0.1 for the time being.
And additional argument in favor of 1.0.1 is that 2.0.0 drops support
for Python 3.5.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)