Skip to content

python3Packages.avro-python3: 1.8.2 -> 1.9.1 #77601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

python3Packages.avro-python3: 1.8.2 -> 1.9.1 #77601

merged 1 commit into from
Jan 21, 2020
+2 −2

Conversation

arnoldfarkas
Copy link
Contributor

@arnoldfarkas arnoldfarkas commented Jan 13, 2020 •
edited
Loading

Motivation for this change

Upgrading avro-python3 from 1.8.2 to 1.9.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@arnoldfarkas arnoldfarkas changed the title python3Packages.avro-python3: init at 1.9.1 python3Packages.avro-python3: 1.8.2 -> 1.9.1 Jan 13, 2020
@jonringer
Copy link
Contributor

please resolve conflicts, the package was added, but this is still a bump

@jonringer
Copy link
Contributor 

git pull -r origin master
# resolve conflicts
git add pkgs
git commit --amend
git push <fork> <branch> --force

@ofborg ofborg bot added 6.topic: python 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 14, 2020
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 21, 2020
@ofborg ofborg bot requested a review from shlevy January 21, 2020 17:05
jonringer
jonringer approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[4 built, 1 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/77601
2 package built:
python37Packages.avro-python3 python38Packages.avro-python3

@jonringer jonringer merged commit c9496d1 into NixOS:master Jan 21, 2020
@WorldQuantOS WorldQuantOS deleted the wq_avro-python3 branch January 22, 2020 14:37
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

@shlevy shlevy

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arnoldfarkas @jonringer @Janik-Haag