Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph: 14.2.5 -> 14.2.6 #77604

Merged
merged 1 commit into from Jan 18, 2020
Merged

ceph: 14.2.5 -> 14.2.6 #77604

merged 1 commit into from Jan 18, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Jan 13, 2020 •
edited

Motivation for this change

Bugfix release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb requested review from lejonet and flokli January 13, 2020 20:06
@srhb
Copy link
Contributor Author

srhb commented Jan 13, 2020 •
edited

Please see #77605 for the backport as well 😃

@ofborg ofborg bot requested review from krav, adevress and johanot January 14, 2020 02:59
lejonet
lejonet approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@lejonet lejonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the single-node test on my machine with flying colours, and the multi-node one failed as expected due to none shared /tmp.
Thumbs up from me :)

@nh2 nh2 merged commit 8fb62ab into NixOS:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lejonet lejonet lejonet approved these changes

@flokli flokli Awaiting requested review from flokli

@krav krav Awaiting requested review from krav

@adevress adevress Awaiting requested review from adevress

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @lejonet @nh2