yoda: provide python3Packages.yoda #77642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Jan 13, 2020
veprbl
force-pushed
the
pr/yoda_to_pythonpackages
branch
2 times, most recently
from
b63ecd6
to
a0746a9
Compare
jonringer
reviewed
Jan 15, 2020
pkgs/top-level/all-packages.nix
Outdated
| @@ -24497,7 +24497,9 @@ in | |||
|
|
|||
| thepeg = callPackage ../development/libraries/physics/thepeg { }; | |||
|
|
|||
| yoda = callPackage ../development/libraries/physics/yoda { }; | |||
| yoda = callPackage ../development/libraries/physics/yoda { | |||
| pythonPackages = python2Packages; | |||
There was a problem hiding this comment.
python2 is EOL, please use python3Packages if possible
There was a problem hiding this comment.
using my other suggestions:
Suggested change
| pythonPackages = python2Packages; | |
| python = python3; |
There was a problem hiding this comment.
I will be switching yoda to use python3 by default, but that, probably, can not be done until I get rivet version 3 working.
veprbl
force-pushed
the
pr/yoda_to_pythonpackages
branch
from
a0746a9
to
74fe916
Compare
veprbl
force-pushed
the
pr/yoda_to_pythonpackages
branch
from
74fe916
to
db4210c
Compare
|
@GrahamcOfBorg build python2Packages.yoda python3Packages.yoda |
jonringer
reviewed
Jan 16, 2020
jonringer
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
diff looks better to me (improvement, would still like to see python3 eventually)
commit LGTM
https://github.com/NixOS/nixpkgs/pull/77642
10 package built:
fastnlo herwig mcgrid rivet yoda python37Packages.yoda python38Packages.yoda sherpa thepeg yoda-with-root
|
@GrahamcOfBorg build fastnlo herwig mcgrid rivet yoda python37Packages.yoda python38Packages.yoda sherpa thepeg yoda-with-root |
|
Let's merge this unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To provide
yodabindings for use withpython3Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)