Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ber_metaocaml: fix install order. #77678

Merged
merged 1 commit into from Feb 4, 2020
Merged

Conversation

darlentar
Copy link
Contributor

@darlentar darlentar commented Jan 14, 2020

Indeed, all standard modules with compiler-libs are not included (
eg. Optcompile).

Motivation for this change

All modules bundled with ocaml are not includes (eg. Optcompile in compiler-libs).

damien@damien:/tmp/nixpkgs$ nix-shell --pure -E 'with import <nixpkgs> {}; runCommand "dummy" {buildInputs=[pkgs.ber_metaocaml];} ""'  -I nixpkgs=.
[nix-shell:/tmp/nixpkgs]$ ocaml -I +compiler-libs
        OCaml version 4.07.1

# open Optcompile;;
Error: Unbound module Optcompile
#

Things done

Move install phase after building phase.
Now we have:

damien@damien:/tmp/nixpkgs$ nix-shell --pure -E 'with import <nixpkgs> {}; runCommand "dummy" {buildInputs=[pkgs.ber_metaocaml];} ""'  -I nixpkgs=.
[nix-shell:/tmp/nixpkgs]$ ocaml -I +compiler-libs
        OCaml version 4.07.1

# open Optcompile;;
# 
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Indeed, all standard modules with compiler-libs are not included (
eg. Optcompile).

closes NixOS#77680
@bcdarwin
Copy link
Member

Looks good to me, builds on x64 non-NixOS Linux.

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants