Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tensorly: init at 0.4.5 #77679

Merged
merged 2 commits into from
Feb 10, 2020
Merged

python3Packages.tensorly: init at 0.4.5 #77679

merged 2 commits into from
Feb 10, 2020
+47 −1

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 14, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@bcdarwin
python3Packages.sparse: mark unbroken (package has been previously up…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
brainrake Márton Boros
GPG key ID: C0D4B398D4F3158F
Expired
Verified
Learn about vigilant mode
c32f432 
…dated)
@bcdarwin
python3Packages.tensorly: init at 0.4.5
67ee9c5
@bcdarwin bcdarwin changed the title Python tensorly python3Packages.tensorly: init at 0.4.5 Jan 14, 2020
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 14, 2020
jonringer
jonringer approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has test 👍

python38 failures are due to pytorch failing on master

[10 built (1 failed), 6 copied (46.9 MiB), 40.9 MiB DL]
error: build of '/nix/store/d66c4ssamflzhhrmwrp8dyf8fagjik09-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77679
1 package failed to build:
python38Packages.tensorly

1 package were built:
python37Packages.tensorly

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.tensorly

@FRidh FRidh merged commit 7059f44 into NixOS:master Feb 10, 2020
@bcdarwin bcdarwin deleted the python-tensorly branch February 10, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @jonringer @FRidh