parallel-full: init SQL and CSV support #77619
Merged
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does |
tomberek
force-pushed
the
tom/parallel_sql
branch
from
822746f to
aba7a2a
Compare
|
Added CSV support and changed name to |
tomberek
changed the title
ofborg
bot
added
the
11.by: package-maintainer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
ofborg
bot
added
the
2.status: merge conflict
Mic92
reviewed
Apr 3, 2020
ofborg
bot
removed
the
2.status: merge conflict
Mic92
reviewed
Apr 3, 2020
pkgs/tools/misc/parallel/default.nix
Outdated
| wrapProgram $out/bin/parallel \ | ||
| --prefix PATH : "${stdenv.lib.makeBinPath [ procps perl ]}" | ||
| --prefix PATH : "${stdenv.lib.makeBinPath [ procps perl ]}" \ | ||
| --set PERL5LIB "${perlPackages.makeFullPerlPath extraPerlPackages}" |
There was a problem hiding this comment.
Since it is just an environment variable added I would make parallel-full a wrapper around parallel that adds these packages.
There was a problem hiding this comment.
Not 100% sure if the wrapper approach i used is correct, but it works. Open to a better approach.
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Mic92
reviewed
Apr 3, 2020
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Mic92
reviewed
Apr 3, 2020
tomberek
force-pushed
the
tom/parallel_sql
branch
from
bdb48ab to
de25fed
Compare
parallel: add pacakges for CSV function parallel: use wrapper to include more libraries parallel: remove unneeded with parallel: remove args Co-Authored-By: Jörg Thalheim <Mic92@users.noreply.github.com> parallel: move default pacakges for full into wrapper
tomberek
force-pushed
the
tom/parallel_sql
branch
from
de25fed to
52f46fe
Compare
Mic92
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Allow using parallel's SQL features.
--sqlmasterand--sqlworkerThings done
Created parallel-extra to prevent adding dependencies to existing users.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after): increased by 14.7M to add SQL support (93.2M -> 107.9M)