Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-libre: updateScript improvements #77618

Merged
merged 3 commits into from Jan 13, 2020
Merged

linux-libre: updateScript improvements #77618

merged 3 commits into from Jan 13, 2020

Conversation

alyssais
Copy link
Member

Motivation for this change

Noticed that lots of commits were being generated that didn’t actually change the hash, and then I noticed that commits weren’t being made automatically even though they were supposed to be. Sorry @NeQuissimus!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
linux-libre.updateScript: fix COMMIT option
f11015a 
Because bash was being run with -u, if COMMIT wasn't set in the
environment the script would just crash here, rather than exiting
successfully.
@alyssais
linux-libre.updateScript: don't update if unchanged
798e9c2 
The revision applies to the whole SVN tree, not just the scripts
directory, so the revision will increment sometimes with no change in
content.
@alyssais
linux-libre.updateScript: fix git commit
48e4317 
With nothing staged and no paths given, previously this wouldn't
actually do anything.
@alyssais alyssais merged commit 1d51514 into NixOS:master Jan 13, 2020
@alyssais alyssais deleted the linux-libre branch January 13, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @NeQuissimus