Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

way-cooler: Remove #77690

Merged
merged 1 commit into from Jan 18, 2020
Merged

way-cooler: Remove #77690

merged 1 commit into from Jan 18, 2020
+13 −7,235

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2020

Motivation for this change

See #77625

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @matthiasbeyer @adisbladis @grahamc

Sorry, something went wrong.

@ghost ghost requested a review from infinisil as a code owner January 14, 2020 17:32
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 14, 2020
infinisil
infinisil requested changes Jan 14, 2020
View reviewed changes
@ghost ghost requested a review from infinisil January 15, 2020 16:58
@ghost
Copy link
Author

ghost commented Jan 15, 2020

@infinisil Done, thanks!

infinisil
infinisil reviewed Jan 15, 2020
View reviewed changes
@ghost ghost requested review from infinisil and worldofpeace January 18, 2020 06:54
@ghost
Copy link
Author

ghost commented Jan 18, 2020

@infinisil @worldofpeace Fixed, thanks!

@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 18, 2020
worldofpeace
worldofpeace approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash your commits 👍

@matthiasbeyer
way-cooler: Remove
29bb16a 
As of 2020-01-09, way-cooler is officially dead:

    http://way-cooler.org/blog/2020/01/09/way-cooler-post-mortem.html

hence, remove the package and the module.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

docs/release-notes: remove way-cooler

way-cooler: show warnings about removal

Apply suggestions from code review

Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>

way-cooler: add suggestion by @infinisil
@ghost
Copy link
Author

ghost commented Jan 18, 2020

@worldofpeace squashed!

@worldofpeace worldofpeace merged commit ffcfb80 into NixOS:master Jan 18, 2020
@worldofpeace
Copy link
Contributor

@worldofpeace squashed!

Thanks for cleaning this up @gnidorah

@ghost
Copy link
Author

ghost commented Jan 19, 2020

@worldofpeace Thanks!

@ghost ghost deleted the way-cooler branch January 19, 2020 02:02
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
Picking up garbage
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@worldofpeace @nixos-discourse @infinisil @matthiasbeyer