[Gecko Bug 1607615] Allow CORS preflights with a default of 5 seconds for expiry if Access-Control-Max-Age hasn't been sent #21170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-Control-Max-Age hasn't been sent The default expiry value is chosen based on what Chromium uses: https://source.chromium.org/chromium/chromium/src/+/master:services/network/public/cpp/cors/preflight_result.cc;l=27;drc=529117e5ed802c91a5cf192a72b4097d27fcb928?originalUrl=https:%2F%2Fcs.chromium.org%2F Differential Revision: https://phabricator.services.mozilla.com/D59032 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1607615 gecko-commit: cd769fb3a217024bea3100681e0907e07d1fdd4a gecko-integration-branch: autoland gecko-reviewers: mayhemer
wpt-pr-bot
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default expiry value is chosen based on what Chromium uses:
https://source.chromium.org/chromium/chromium/src/+/master:services/network/public/cpp/cors/preflight_result.cc;l=27;drc=529117e5ed802c91a5cf192a72b4097d27fcb928?originalUrl=https:%2F%2Fcs.chromium.org%2F
Differential Revision: https://phabricator.services.mozilla.com/D59032
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1607615
gecko-commit: cd769fb3a217024bea3100681e0907e07d1fdd4a
gecko-integration-branch: autoland
gecko-reviewers: mayhemer