lib/types: prioritise coercedType in coercedTo #77691
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more intuitively matches
types.either
and allows paths to be coerced to submodules again.Motivation for this change
#76861's changes allowed strings to typecheck as submodules when they appear to be a path (start with a slash). A somewhat common use of
coercedTo
is to turn single values into an attrset/submodule:with types; coercedTo str (value: { inherit value; }) valueSubmodule
.coercedTo
currently will prioritise the final type if possible, and now that submodules can be set from paths this causes havoc when the module system tries to import what was previously meant to be just a config value.A similar issue occurs with
types.either
, and #76861 suggests changing the order of the types as a solution. That approach isn't possible here andcoercedTo
feels backward in comparison, so this change reverses its behaviour.cc @infinisil who made the original submodule change and suggested this patch
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)