Unborking the accept-ch-lifetime CH WPT #21144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 13, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1994422
branch
3 times, most recently
from
8347e49
to
4f76360
Compare
Due to some broswer-state related flakiness, the "accept-ch-lifetime.tentative.https.html" test was split into several different files. Also, all mentions of "lifetime" in the tests was removed to keep up to date with the Client Hint spec. Change-Id: I1c06b82d8cbe8bd6e304f5c1fa1d058b100a825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994422 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#731583}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1994422
branch
from
4f76360
to
52312a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some broswer-state related flakiness, the
"accept-ch-lifetime.tentative.https.html" test was split
into several different files. Also, all mentions of "lifetime"
in the tests was removed to keep up to date with the Client Hint
spec.
Change-Id: I1c06b82d8cbe8bd6e304f5c1fa1d058b100a825c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994422
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#731583}