Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontforge: 20190413 -> 20190801 #77676

Merged
merged 1 commit into from Feb 16, 2020
Merged

fontforge: 20190413 -> 20190801 #77676

merged 1 commit into from Feb 16, 2020

Conversation

erictapen
Copy link
Member

@erictapen erictapen commented Jan 14, 2020 •
edited

Motivation for this change

Update fontforge to latest release.

Things done
  • Init libuninameslist at 20190701 as it is a new dependency to fontforge
  • Remove gnulib as a dependency, as it is not used anymore by fontforge.
  • Remove a non-applying patch (The file it patched does not exist anymore).
  • Add myself as maintainer.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@erictapen
Copy link
Member Author

@GrahamcOfBorg build ffmpeg scribus libreoffice fontforge fontforge-gtk

@erictapen erictapen changed the base branch from master to staging January 16, 2020 22:48
@erictapen erictapen changed the title [WIP] fontforge: 20190413 -> 20190801 fontforge: 20190413 -> 20190801 Jan 16, 2020
@FRidh FRidh added this to WIP in Staging via automation Jan 29, 2020
@erictapen
fontforge: 20190413 -> 20190801
c2282fb 
- Init libuninameslist at 20190701 as it is a new dependency to fontforge
- Remove gnulib, as it is not used anymore
- Remove a non-applying patch
- Add myself as maintainer
@FRidh FRidh merged commit 4496f8f into NixOS:staging Feb 16, 2020
Staging automation moved this from WIP to Done Feb 16, 2020
@erictapen
Copy link
Member Author

erictapen commented Feb 18, 2020 •
edited

Thanks for merging! Any chance this could get backported to staging-20.03? Would make it easier for me to use fontforge in the next six months, without needing to rebuild thousands of packages.

Or should I rather file a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erictapen @FRidh