Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sentry-sdk: add missing test dependency #77687

Merged
merged 1 commit into from Jan 14, 2020
Merged

python3Packages.sentry-sdk: add missing test dependency #77687

merged 1 commit into from Jan 14, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Jan 14, 2020

Motivation for this change

The tests of this package will fail with

ModuleNotFoundError: No module named 'sqlalchemy'

when sqlalchemy is not part of the test inputs, which prevents building the package. Therefore, add it as a checkInput.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/) (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ruuda
python3Packages.sentry-sdk: add missing test dep
d8878ad 
The tests will fail with

    ModuleNotFoundError: No module named 'sqlalchemy'

when sqlalchemy is not part of the test inputs, which prevents building
the package. Therefore, add it as a checkInput.
@ruuda
Copy link
Contributor Author

ruuda commented Jan 14, 2020

CC @gebner, please take a look.

@ofborg ofborg bot requested a review from gebner January 14, 2020 16:34
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.sentry-sdk python3Packages.sentry-sdk python38Packages.sentry-sdk

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.sentry-sdk python3Packages.sentry-sdk

@jonringer
Copy link
Contributor

fixes a broken build

failures are outside scope of PR

@jonringer jonringer merged commit a521953 into NixOS:master Jan 14, 2020
@ruuda ruuda deleted the fix-sentry-sdk branch October 6, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruuda @jonringer