Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable further pass tests that end up relying on gpg-agent on… #77634

Merged
merged 1 commit into from Jan 14, 2020
Merged

Disable further pass tests that end up relying on gpg-agent on… #77634

merged 1 commit into from Jan 14, 2020

Conversation

jwiegley
Copy link
Contributor

Motivation for this change

Fixes #58975 on Darwin. Several of the pass test yield the following error that causes a spurious failure:

gpg: can't connect to the agent: File name too long
gpg: decryption failed: No secret key

This PR simply disables those tests, along the lines of what was being done before for another such test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jwiegley jwiegley self-assigned this Jan 13, 2020
@jwiegley jwiegley changed the title Disable further pass tests that end up relying on gpg-agent on Darwin Disable further pass tests that end up relying on gpg-agent on… Jan 14, 2020
@jwiegley jwiegley merged commit ff3f9d8 into master Jan 14, 2020
@jwiegley jwiegley deleted the johnw/58975 branch January 14, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk Awaiting requested review from danieldk

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

@the-kenny the-kenny Awaiting requested review from the-kenny

@tadfisher tadfisher Awaiting requested review from tadfisher

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees

@jwiegley jwiegley

Labels
0.kind: bug 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

password-store-1.7.3 fails to build on darwin
1 participant
@jwiegley