Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many Fetch tests do not run in service workers #21163

Closed
annevk opened this issue Jan 14, 2020 · 4 comments · Fixed by #26296
Closed

Many Fetch tests do not run in service workers #21163

annevk opened this issue Jan 14, 2020 · 4 comments · Fixed by #26296

Comments

@annevk
Copy link
Member

annevk commented Jan 14, 2020

Mainly due to defaulting of .any.js and not inserting the necessary boilerplate.

@muodov
Copy link
Contributor

muodov commented Oct 7, 2020

This looks like a good one to get familiar with how tests files are processed and executed.
I'd like to work on this. @annevk any pointers or hints where to start would be appreciated :)

@annevk
Copy link
Member Author

annevk commented Oct 8, 2020

@muodov reading https://web-platform-tests.org/writing-tests/testharness.html#tests-for-other-or-multiple-globals-any-js would go a long way. Adding // META: global=window,worker to existing .any.js tests and converting .html tests (if any) to .any.js tests would be most of the work change-wise, I think. And then verifying that the tests still function in these additional environments and there are no new failures. (And if there are, that's exciting, you'll have found bugs.)

@muodov
Copy link
Contributor

muodov commented Oct 18, 2020

One complication of this is that service workers implies https, and this breaks some tests with cross-scheme errors ("Mixed Content" and such).
I am going to try and add serviceworker global wherever I can, and then go and fix the new failures caused by Mixed Content one by one. I guess it will be similar to this pr

@annevk
Copy link
Member Author

annevk commented Oct 20, 2020

Ah yeah, that's right. Sorry for not giving a fair warning about that. I think it's also fine to leave any such tests alone for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants