Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: remove versions 1.62, 1.63, and 1.64 #77658

Merged
merged 1 commit into from Mar 13, 2020
Merged

boost: remove versions 1.62, 1.63, and 1.64 #77658

merged 1 commit into from Mar 13, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Jan 14, 2020

These are relatively old, expensive to compile/cache, and not used by any
packages in the distribution.

My general understanding is that we try hard not to have old versions of
packages in the distribution, unless the old version is specifically needed for
building a package; if there's a special exception for boost let me know.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
boost: remove versions 1.62, 1.63, and 1.64
f45e9f1 
These are relatively old, expensive to compile/cache, and not used by any
packages in the distribution.
@jtojnar jtojnar added this to To do in Picking up garbage via automation Jan 14, 2020
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Jan 14, 2020
jonringer
jonringer approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nothing changed
https://github.com/NixOS/nixpkgs/pull/77658
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-77658/shell.nix

nothing was using this and the 20.03 branch off has already happened

@alyssais alyssais merged commit f5140d1 into NixOS:master Mar 13, 2020
Picking up garbage automation moved this from In progress to Done Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @jonringer @alyssais