Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ignite: init at 0.2.1 #77685

Merged
merged 2 commits into from Feb 27, 2020
Merged

python3Packages.ignite: init at 0.2.1 #77685

merged 2 commits into from Feb 27, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin changed the title python3Packages.ignite python3Packages.ignite: init at 0.2.1 Jan 14, 2020
@jonringer
Copy link
Contributor

also, please resovle conflicts

git pull -r origin master

@bcdarwin bcdarwin force-pushed the python3-ignite branch 2 times, most recently from c9b02f5 to a2c9d38 Compare January 14, 2020 19:21
bcdarwin
bcdarwin commented Jan 14, 2020
View reviewed changes
Copy link
Member Author

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase done.

@jonringer
Copy link
Contributor

unfortunately, pytorch relies on this.... takes forever to build it as part of a review :(

@bcdarwin
Copy link
Member Author

I'm not certain that including cudatoolkit is ideal since a package might depend on pynvml unconditionally and use its functionality to test for CUDA or something, but from the perspective of pynvml working correctly it seemed right.

@bcdarwin
Copy link
Member Author

bcdarwin commented Jan 14, 2020 •
edited

Also, ignite could drop the pynvml dependency (making it possible to build against lighter Pytorch derivations).

jonringer
jonringer approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests for ignite 👍

failure broken by python38Packages.pytorch

[9 built (1 failed), 103 copied (818.1 MiB), 170.2 MiB DL]
error: build of '/nix/store/wr425dbdcz6b140vwim73pkq9a9zz6q3-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/77685
1 package failed to build:
python38Packages.ignite

3 package were built:
python37Packages.ignite python37Packages.pynvml python38Packages.pynvml

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.ignite python37Packages.pynvml python38Packages.pynvml

@marsam marsam merged commit dfad6d1 into NixOS:master Feb 27, 2020
@bcdarwin bcdarwin deleted the python3-ignite branch February 27, 2020 15:56
dotlambda
dotlambda reviewed Mar 6, 2024
View reviewed changes
pkgs/development/python-modules/pynvml/default.nix

meta = with lib; {
description = "Python bindings for the NVIDIA Management Library";
homepage = https://www.nvidia.com;
Copy link
Member

@dotlambda dotlambda Mar 6, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a proper homepage! Fixed in #293631.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcdarwin @jonringer @dotlambda @marsam