Skip to content

Revert "Re-revert "awscli: Get rid of runtime -dev dependencies"" #77686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

Revert "Re-revert "awscli: Get rid of runtime -dev dependencies"" #77686

merged 1 commit into from
Jan 16, 2020
+0 −9

Conversation

alyssais
Copy link
Member

Motivation for this change

This reverts commit a1eacb9.

Adding dev outputs to python packages means they can't be included in
a Python environment created with python3.withPackages, because
makePythonPath will include the dev output, which is empty apart from
nix-support, rather than the out output, which contains all the Python
code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@alyssais alyssais requested review from edolstra, vcunat and FRidh January 14, 2020 15:32
@alyssais alyssais requested a review from jonringer as a code owner January 14, 2020 15:32
@alyssais
Revert "Re-revert "awscli: Get rid of runtime -dev dependencies""

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alyssais Alyssa Ross
GPG key ID: F9DBED4859B271C0
Expired
Verified
Learn about vigilant mode
76af9e8 
This reverts commit a1eacb9.

Adding dev outputs to python packages means they can't be included in
a Python environment created with python3.withPackages, because
makePythonPath will include the dev output, which is empty apart from
nix-support, rather than the out output, which contains all the Python
code.
@alyssais alyssais mentioned this pull request Jan 14, 2020
Merged
10 tasks
@globin globin merged commit aa489ad into NixOS:staging Jan 16, 2020
@alyssais alyssais deleted the urllib3 branch January 16, 2020 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@edolstra edolstra

@vcunat vcunat

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @vcunat @FRidh @globin