[Gecko Bug 836567] Part 2: Replace inapplicable tests with a web-platform-test for reloading after setting javascript: URI, and fix other tests relying on javascript: URI. #21165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding after setting javascript: URI, and fix other tests relying on javascript: URI. Some notes about the changes: Both test_bug384014.html and test_bug123696.html were testing reloading of javascript: URI. The expected result of the iframes after reloading would become about:blank. I deleted both file and instead wrote with web-platform-test to cover reloading of javascript: URI since wpt is more preferable. storage-cache-error.html was utilizing javascript: URI to test bug 1262766. javascript: URI would cause CacheStorage::Keys to throw a dom security exception because the URI's principal (which did not match the principal of the document in this case!) was a nullpricipal. With my patches the iframe's URL would no longer be the javascript: URI, so it's no longer applicable for the test case. Instead we can test what bug 1262766 was originally about - that CacheStorage::Keys would throw a dom security exception if it's in a private browsing window. Differential Revision: https://phabricator.services.mozilla.com/D59465 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=836567 gecko-commit: 68447a9ccb6afbde6bf3817c72bae89a5f7d242d gecko-integration-branch: autoland gecko-reviewers: Gijs, miker
wpt-pr-bot
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes about the changes:
Both test_bug384014.html and test_bug123696.html were testing reloading of
javascript: URI. The expected result of the iframes after reloading would
become about:blank. I deleted both file and instead wrote with
web-platform-test to cover reloading of javascript: URI since wpt is more
preferable.
storage-cache-error.html was utilizing javascript: URI to test bug 1262766.
javascript: URI would cause CacheStorage::Keys to throw a dom security
exception because the URI's principal (which did not match the principal of the
document in this case!) was a nullpricipal. With my patches the iframe's URL
would no longer be the javascript: URI, so it's no longer applicable for the
test case. Instead we can test what bug 1262766 was originally about - that
CacheStorage::Keys would throw a dom security exception if it's in a private
browsing window.
Differential Revision: https://phabricator.services.mozilla.com/D59465
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=836567
gecko-commit: 68447a9ccb6afbde6bf3817c72bae89a5f7d242d
gecko-integration-branch: autoland
gecko-reviewers: Gijs, miker