Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glog: remove static flag #77682

Merged
merged 1 commit into from Jan 14, 2020
Merged

glog: remove static flag #77682

merged 1 commit into from Jan 14, 2020

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 14, 2020

Motivation for this change

Follow up for #77047.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @veprbl @FRidh

@tobim tobim mentioned this pull request Jan 14, 2020
Merged
10 tasks
@vcunat vcunat self-assigned this Jan 14, 2020
vcunat added a commit that referenced this pull request Jan 14, 2020
@vcunat
Merge #77682: glog: remove static flag
018e297 
It was re-introduced by incorrect merge-conflict resolution.
@vcunat vcunat merged commit d48a993 into NixOS:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobim @vcunat