Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Make callout marks & prompts unselectable #77683

Merged
merged 2 commits into from Jan 14, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 14, 2020

As noticed by @davidak, this was actually broken.

This will make copying examples easier.

Weirdly, no-one seems to have noticed this was broken.
To make example copying easier.
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix! ✨

It works and code looks sane. (but i'm no CSS expert)

Screenshot from 2020-01-14 16-43-42

@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 14, 2020

Also noticed that there are spaces before callouts but the default stylesheet does not mark the <span>s produced by <co> so I did not figure out a nice way of doing that. Asked upstream.

@grahamc grahamc requested a review from samueldr January 14, 2020 17:20
@grahamc grahamc merged commit 6ed0b0a into NixOS:master Jan 14, 2020
@grahamc
Copy link
Member

grahamc commented Jan 14, 2020

@jtojnar can you backport?

@jtojnar jtojnar deleted the prompt-no-select branch January 18, 2020 02:04
@jtojnar
Copy link
Contributor Author

jtojnar commented Jan 18, 2020

Cherry-picked in 273f15c and d126556.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants