Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/transmisison: Transmission torrent test fix #77664

Merged
merged 3 commits into from Jan 14, 2020
Merged

nixos/transmisison: Transmission torrent test fix #77664

merged 3 commits into from Jan 14, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Jan 14, 2020 •
edited

Motivation for this change

The transmission NixOS module threw warnings and the bittorrent test did not work any longer due to changes in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @flokli @worldofpeace

@tfc
Copy link
Contributor Author

tfc commented Jan 14, 2020

@GrahamcOfBorg test transmission bittorrent

@tfc tfc force-pushed the transmission-torrent-test-fix branch from e0078c0 to adf5642 Compare January 14, 2020 09:23
@flokli
Copy link
Contributor

flokli commented Jan 14, 2020

@GrahamcOfBorg test transmission bittorrent

@flokli flokli merged commit 4b4e59b into NixOS:master Jan 14, 2020
@flokli
Copy link
Contributor

flokli commented Jan 14, 2020

Thanks!

@tfc tfc deleted the transmission-torrent-test-fix branch January 15, 2020 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfc @flokli