systemd-networkd: add configuration for XFRM interfaces #77665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andir
approved these changes
Jan 21, 2020
| @@ -172,6 +172,14 @@ let | |||
| (assertValueOneOf "AllSlavesActive" boolValues) | |||
| ]; | |||
|
|
|||
| checkXfrm = checkUnitConfig "Xfrm" [ | |||
| (assertOnlyFields [ | |||
| "InterfaceId" "Independent" | |||
There was a problem hiding this comment.
This looks okay according to the man pages usage of the Xfrm section:
[XFRM] SECTION OPTIONS
The "[Xfrm]" section accepts the following keys:
InterfaceId=
Sets the ID/key of the xfrm interface which needs to be associated with a SA/policy. Can be decimal or hexadecimal, valid range is 0-0xffffffff,
defaults to 0.
Independent=
Takes a boolean. If set to "no", the xfrm interface should have an underlying device which can be used for hardware offloading. Defaults to
"no". See systemd.network(5) for how to configure the underlying device.
For more detail information see Virtual xfrm interfaces[16]
This does not look complete when looking at the examples:
[Xfrm]
Name=xfrm0
Kind=xfrm
[Xfrm]
Independent=yes
I guess that first [Xfrm] there should have have been [NetDev] then everything checks out.
I filed an upstream PR: systemd/systemd#14630
flokli
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the option(s) to create and manage XFRM interfaces via systemd-networkd. All the options have been added. Tested on a system running 19.09.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)