-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the ReadFromMessage method of the adaptive-step size integrators to be static #2437
Conversation
@@ -25,6 +25,7 @@ namespace internal_embedded_explicit_generalized_runge_kutta_nyström_integrator | |||
using numerics::EstrinEvaluator; | |||
using numerics::LegendrePolynomial; | |||
using quantities::Abs; | |||
using quantities::Length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An aborted attempt at adding a test.
// All the case branches in a switch on the serialized adaptive-step size | ||
// integrator kind. Depending on the nature of the integrator, each case branch | ||
// calls one of the given actions, which must be 1-argument macros. | ||
// It has not escape our notice that the acronym is a fair characterization of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo.
integrators/integrators.hpp
Outdated
@@ -211,21 +215,12 @@ class AdaptiveStepSizeIntegrator : public Integrator<ODE_> { | |||
|
|||
virtual void WriteToMessage( | |||
not_null<serialization::AdaptiveStepSizeIntegrator*> message) const = 0; | |||
template<typename S = typename ODE::SystemState, | |||
typename = std::enable_if_t<base::is_serializable_v<S>>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to allow deserialization of integrators for non-serializable frames (both ASS and FSS).
This is a follow-up of #2404.