Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the ReadFromMessage method of the adaptive-step size integrators to be static #2437

Merged
merged 7 commits into from
Jan 14, 2020

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Jan 11, 2020

This is a follow-up of #2404.

@@ -25,6 +25,7 @@ namespace internal_embedded_explicit_generalized_runge_kutta_nyström_integrator
using numerics::EstrinEvaluator;
using numerics::LegendrePolynomial;
using quantities::Abs;
using quantities::Length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sorry, something went wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An aborted attempt at adding a test.

Sorry, something went wrong.

@@ -211,21 +215,12 @@ class AdaptiveStepSizeIntegrator : public Integrator<ODE_> {

virtual void WriteToMessage(
not_null<serialization::AdaptiveStepSizeIntegrator*> message) const = 0;
template<typename S = typename ODE::SystemState,
typename = std::enable_if_t<base::is_serializable_v<S>>>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to allow deserialization of integrators for non-serializable frames (both ASS and FSS).

@eggrobin eggrobin added the LGTM label Jan 13, 2020
@pleroy pleroy merged commit d5eaccf into mockingbirdnest:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants