rofimoji: init #78110
rofimoji: init #78110
Conversation
|
In the result output we get a bunch of files that isn't needed such as: |
| dontBuild = true; | ||
|
|
||
| buildInputs = [ | ||
| makeWrapper |
There was a problem hiding this comment.
This should be in nativeBuildInputs
| ''; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/fdw/rofimoji; |
There was a problem hiding this comment.
The URL syntax is on it's way out since this RFC is approved: NixOS/rfcs#45
So it should be a quoted string.
|
|
||
| stdenv.mkDerivation rec { | ||
| pname = "rofimoji"; | ||
| version = "unstable-2020-01-12"; |
There was a problem hiding this comment.
They have done releases, is there a specific reason to not use a stable release?
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
|
Can I bump this? A Rofimoji package would be cool to have in nixpkgs |
stale
bot
removed
the
2.status: stale
|
You'd need to address the comments from the other maintainers. Currently I've included this in my NixOS config from just my /home nix files. |
|
I'm not sure this package is needed since #83753. So I guess the need is covered there? |
|
Perhaps,I haven't checked the package, but it sounds similar.
…On Wed, Aug 26, 2020 at 10:33 AM Elis Hirwing ***@***.***> wrote:
I'm not sure this package is needed since #83753
<#83753>. So I guess the need is
covered there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78110 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZNCZ44X7AGGO36ZBKOADSCS3EBANCNFSM4KJFZVUQ>
.
--
Raitis Veinbahs, +371 2236 4708
|
|
exists as v4.3.0 in nixpks |
It seems to be working. It's a just couple of python scripts with CSVs inside.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)