Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinnamon.cinnamon-settings-daemon: init at 4.4.0 #78144

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

mkg20001
Copy link
Member

Motivation for this change

Cinnamon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001 mkg20001 requested a review from worldofpeace January 21, 2020 01:19
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jan 21, 2020
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 21, 2020
@mkg20001 mkg20001 force-pushed the pkg/csd branch 2 times, most recently from 72d003f to 6116d63 Compare January 21, 2020 01:33
@mkg20001 mkg20001 force-pushed the pkg/csd branch 2 times, most recently from cbcf674 to 029c184 Compare January 21, 2020 01:49
@mkg20001 mkg20001 force-pushed the pkg/csd branch 2 times, most recently from 25e48a0 to 9b6708b Compare January 21, 2020 02:22

Verified

This commit was signed with the committer’s verified signature.
mkg20001 Maciej Krüger
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@worldofpeace worldofpeace requested a review from jtojnar January 21, 2020 20:07
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@worldofpeace worldofpeace merged commit deb6770 into NixOS:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants