Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release doesn't compile #315

Closed
david-sawatzke opened this issue Nov 22, 2019 · 4 comments
Closed

Latest release doesn't compile #315

david-sawatzke opened this issue Nov 22, 2019 · 4 comments

Comments

@david-sawatzke
Copy link
Contributor

The current release v0.5.0 soon won't compile, when the old borrow checker is removed. master doesn't have this issue. Seems like a good idea to release a new version before this becomes a major hassle.

$ git checkout v0.5.0
$ cargo build
...
warning[E0713]: borrow may still be in use when destructor runs
  --> src/socket/ref_.rs:61:9
   |
39 | impl<'a, T: Session + 'a> Ref<'a, T> {
   |      -- lifetime `'a` defined here
...
61 |         ref_.socket
   |         ^^^^^^^^^^^ returning this value requires that `*ref_.socket` is borrowed for `'a`
62 |     }
   |     - here, drop of `ref_` needs exclusive access to `*ref_.socket`, because the type `socket::ref_::Ref<'_, T>` implements the `Drop` trait
   |
   = warning: this error has been downgraded to a warning for backwards compatibility with previous releases
   = warning: this represents potential undefined behavior in your code and this warning will become a hard error in the future
   = note: for more information, try `rustc --explain E0729`
@david-sawatzke
Copy link
Contributor Author

Rust 1.40.0 is out, the released version doesn't compile anymore

@david-sawatzke david-sawatzke changed the title New release Latest release doesn't compile Jan 3, 2020
@stlankes
Copy link
Contributor

stlankes commented Jan 4, 2020

Please update the version at crate.io. The current version in the repository seems to work...

@whitequark
Copy link
Contributor

I'll do this soon.

@whitequark
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants