Skip to content

dasher: init at 2018-04-03 #78051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2020
Merged

dasher: init at 2018-04-03 #78051

merged 2 commits into from
Jan 23, 2020
+60 −0

Conversation

Profpatsch
Copy link
Member

Motivation for this change

adds dasher

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc you might be interested in this tool

Sorry, something went wrong.

worldofpeace
worldofpeace reviewed Jan 19, 2020
View reviewed changes
nixos/modules/services/desktops/gnome3/at-spi2-core.nix
Comment on lines +22 to +23
Enable this if you get the error or warning
<literal>The name org.a11y.Bus was not provided by any .service files</literal>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add these. We more need a mechanism to check if you're missing a certain dbus interface.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t have the mechanism, so this is the next best thing requiring the least effort.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtojnar I believe a note like this used to be in the package description?
I'm still not sure how I feel about it *shrug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it would have saved me from 10 minutes of random internet search, that’s for sure

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 19, 2020
@worldofpeace worldofpeace changed the title init: dasher at 2018-04-03 dasher: init at 2018-04-03 Jan 19, 2020
@Profpatsch Profpatsch mentioned this pull request Jan 20, 2020
Merged
@Profpatsch
Copy link
Member Author

Profpatsch commented Jan 23, 2020 •
edited
Loading

@worldofpeace When I go to File > Import From Training Text and add a text file, it hangs on “Training on User Text 100%”. Maybe you have a idea what goes wrong here. Maybe it’s just a bug in the app.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jan 23, 2020 •
edited
Loading

@worldofpeace When I go to File > Import From Training Text and add a text file, it hangs on “Training on User Text 100%”. Maybe you have a idea what goes wrong here. Maybe it’s just a bug in the app.

I'm not sure how to use this tool, perhaps you can run it with G_MESSAGES_DEBUG=all to see if there's any output. A guess could be is it's not good at reporting its progress and goes from 1% to 100% while still having a lot to do.

worldofpeace
worldofpeace approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packaging LGTM.

@worldofpeace
Copy link
Contributor

I saw it in some of the output, and it’s used by lots of other packages. Gnome stuff is a walk in the dark for me.

At least we finally have documentation for it now https://nixos.org/nixpkgs/manual/#sec-language-gnome 😄

@Profpatsch
Copy link
Member Author

At least we finally have documentation for it now https://nixos.org/nixpkgs/manual/#sec-language-gnome smile

yeah, that was helpful when packaging.

@Profpatsch Profpatsch merged commit 166d824 into NixOS:master Jan 23, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/january-2020-in-nixos/5771/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Profpatsch @worldofpeace @nixos-discourse