Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages_12_x: add node-gyp #78070

Merged
merged 1 commit into from Jan 23, 2020
Merged

nodePackages_12_x: add node-gyp #78070

merged 1 commit into from Jan 23, 2020

Conversation

danjuv
Copy link
Contributor

@danjuv danjuv commented Jan 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danjuv
Copy link
Contributor Author

danjuv commented Jan 20, 2020 •
edited

I'm not so sure if I generated this correctly, I followed the instructions in https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/node.section.md, seems like a lot of spurious changes, which could be expected.

Unsure who maintains this, so I'll go along with the suggested reviewer. Apologies if this is the wrong person

@uri-canva
Copy link
Contributor

cc @Mic92
ping @svanderburg

@Mic92 Mic92 merged commit ace14c5 into NixOS:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danjuv @uri-canva @Mic92