b2sdk: Add b2sdk python module. #78116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will rebase when #78124 is in. |
|
#78124 was merged, please rebase |
|
Ok has been rebased. |
jonringer
reviewed
Jan 23, 2020
| ''; | ||
|
|
||
| checkInputs = [ mock pyflakes yapf nose ]; | ||
| propagatedBuildInputs = [ arrow logfury requests setuptools six tqdm yapf ]; |
There was a problem hiding this comment.
Suggested change
| propagatedBuildInputs = [ arrow logfury requests setuptools six tqdm yapf ]; | |
| propagatedBuildInputs = [ arrow logfury requests setuptools six tqdm yapf ] | |
| ++ lib.optionals isPy27 [ futures ]; |
warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/rich7lsi69jzm0nw84fnza1sr3dnizhb-python2.7-b2sdk-1.0.2.drv' failed with exit code 1; last 10 log lines:
Executing pipInstallPhase
/build/b2sdk-1.0.2/dist /build/b2sdk-1.0.2
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Processing ./b2sdk-1.0.2-py2-none-any.whl
Requirement already satisfied: requests>=2.9.1 in /nix/store/rrxs8mkw2x96ia6jx2vakd3lrkb59fsz-python2.7-requests-2.22.0/lib/python2.7/site-packages (from b2sdk==1.0.2) (2.22.0)
Requirement already satisfied: logfury>=0.1.2 in /nix/store/agq9y4w54cwnijylsp51ql64k5qr5jhs-python2.7-logfury-0.1.2/lib/python2.7/site-packages (from b2sdk==1.0.2) (0.1.2)
Requirement already satisfied: tqdm>=4.5.0 in /nix/store/5ivwbb6zajiq63jdhm9spks5lkvjivkg-python2.7-tqdm-4.40.2/lib/python2.7/site-packages (from b2sdk==1.0.2) (4.40.2)
Requirement already satisfied: setuptools in /nix/store/pfibnhl0w46pa2kyn47fdr5h8s466xh6-python2.7-setuptools-44.0.0/lib/python2.7/site-packages (from b2sdk==1.0.2) (44.0.0.post20200106)
ERROR: Could not find a version that satisfies the requirement futures>=3.0.5; python_version < "3.2" (from b2sdk==1.0.2) (from versions: none)
ERROR: No matching distribution found for futures>=3.0.5; python_version < "3.2" (from b2sdk==1.0.2)
cannot build derivation '/nix/store/dl7yczsczhrmhvw1s86c9gmyh308b3id-env.drv': 1 dependencies couldn't be built
jtojnar
reviewed
Feb 10, 2020
| @@ -466,6 +466,8 @@ in { | |||
|
|
|||
| azure-multiapi-storage = callPackage ../development/python-modules/azure-multiapi-storage { }; | |||
|
|
|||
| b2sdk = callPackage ../development/python-modules/b2sdk {}; | |||
There was a problem hiding this comment.
Suggested change
| b2sdk = callPackage ../development/python-modules/b2sdk {}; | |
| b2sdk = callPackage ../development/python-modules/b2sdk {}; |
There was a problem hiding this comment.
Looks like there are tabs all over. I recommend using something like https://github.com/nix-community/nixpkgs-fmt.
|
I haven't had any time to look at this again and I've since stopped personally using B2. #95714 is in progress that is very similar and I can help review it. |
|
sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The B2 cli and duplicity applications should be depending on this instead of the current situation where B2 is exporting something like this.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)