Skip to content

cinnamon.cinnamon-translations: init at 4.4.0 #78119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2020
Merged

cinnamon.cinnamon-translations: init at 4.4.0 #78119

merged 1 commit into from
Jan 21, 2020
+32 −0

Conversation

mkg20001
Copy link
Member

Motivation for this change

Needed for cinnamon port

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 20, 2020
@mkg20001 mkg20001 force-pushed the pkg/cinnamon-translations branch from ed47919 to 9ef6846 Compare January 21, 2020 00:58
@mkg20001 mkg20001 requested a review from worldofpeace January 21, 2020 00:58
worldofpeace
worldofpeace approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting to have all the translations in one place, but I guess maybe that's easier for certain infras.
Verified all the things.

@worldofpeace
Copy link
Contributor

@mkg20001 Whitespace nit.

@mkg20001 mkg20001 force-pushed the pkg/cinnamon-translations branch from 9ef6846 to 1170b0e Compare January 21, 2020 01:00
@worldofpeace worldofpeace merged commit 628164c into NixOS:master Jan 21, 2020
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Jan 21, 2020
@worldofpeace
Copy link
Contributor

Ah crap we're missing a license meta attr here @mkg20001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkg20001 @worldofpeace