Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zanshin: 2019-07-28 -> 0.5.71 #78155

Merged
merged 1 commit into from Feb 3, 2020
Merged

zanshin: 2019-07-28 -> 0.5.71 #78155

merged 1 commit into from Feb 3, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 21, 2020

Motivation for this change

https://zanshin.kde.org/2020/01/14/zanshin-0.5.71/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from zraexy January 21, 2020 12:09
zraexy
zraexy approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@zraexy zraexy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good otherwise.

pkgs/applications/office/zanshin/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot requested a review from zraexy January 29, 2020 04:10
@dtzWill dtzWill merged commit d18b1ee into NixOS:master Feb 3, 2020
@dtzWill dtzWill deleted the update/zanshin-0.5.71 branch February 3, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zraexy zraexy Awaiting requested review from zraexy

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @zraexy