Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdfpc: Fix gstreamer video playback issue #73321 #78125

Merged
merged 1 commit into from Jan 31, 2020
Merged

pdfpc: Fix gstreamer video playback issue #73321 #78125

merged 1 commit into from Jan 31, 2020

Conversation

KnairdA
Copy link
Contributor

@KnairdA KnairdA commented Jan 20, 2020 •
edited by veprbl

Motivation for this change

Fixing issue #73321 which prevents videos from being played in PDF presentations which is one of the main features provided by pdfpc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fixes: #73321

@ofborg ofborg bot requested a review from pSub January 20, 2020 19:24
@worldofpeace
Copy link
Contributor

Weird that it didn't bail out https://github.com/pdfpc/pdfpc/blob/66bbd9c1c9626ac23fe9b391775e2680b05af332/src/CMakeLists.txt#L17

@veprbl
Copy link
Member

veprbl commented Jan 20, 2020

For some reason this didn't work for me. I do:

nixpkgs-review pr 78125 
wget https://github.com/pdfpc/pdfpc/releases/download/v4.3.0/pdfpc-video-example.zip
nix run nixpkgs.unzip -c unzip pdfpc-video-example.zip
cd pdfpc-video-example/
pdfpc -wS video-example.pdf

and it freezes the viewer. If I do it without "-wS", it just flips to the next page when I click.

@KnairdA
Copy link
Contributor Author

KnairdA commented Jan 22, 2020

Do you get any error message? When it failed for me the viewer did not freeze but simply print out that some codec was missing. To make sure, I verified that it works not only using my own files but also using the example linked in your comment. Any ideas?

@veprbl
Copy link
Member

veprbl commented Jan 27, 2020

@KnairdA
I don't get any error, like before. If I run nix-shell with --pure flag I get "Could not acquire DBus bus." on start. If I run with fluxbox instead of mate I also get

(pdfpc:1185): dbind-WARNING **: 21:24:36.351: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files

@veprbl
Copy link
Member

veprbl commented Jan 30, 2020

@KnairdA
If you are sure that this fixes the problem for you (you confirm that it doesn't work for you without this patch), then let's merge this PR.

@KnairdA
Copy link
Contributor Author

KnairdA commented Jan 30, 2020

Yes, that is the case. With this patch both the "pdfpc-video-example" and various other videos I tested work without issue.

@jtojnar jtojnar merged commit 1457637 into NixOS:master Jan 31, 2020
@worldofpeace
Copy link
Contributor

@KnairdA
I don't get any error, like before. If I run nix-shell with --pure flag I get "Could not acquire DBus bus." on start. If I run with fluxbox instead of mate I also get

(pdfpc:1185): dbind-WARNING **: 21:24:36.351: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: The name org.a11y.Bus was not provided by any .service files

That means services.gnome3.at-spi2-core isn't enabled.

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@jtojnar @anna328p
Merge pull request NixOS#78125 from KnairdA/master
ffe7989 
pdfpc: Fix gstreamer video playback issue NixOS#73321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pdfpc fails to play video
4 participants
@KnairdA @worldofpeace @veprbl @jtojnar