New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pymetno: init at 0.5.0 #78132
pymetno: init at 0.5.0 #78132
Conversation
src = fetchPypi { | ||
inherit pname version; | ||
sha256 = "e532544495200210407e3d68f719c271435da6f3bfe696e708b1d5d603a21948"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running build_ext
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
Finished executing setuptoolsCheckPhase
/nix/store/lkll7y216pk69jl93kizxgmi9hnpv5wy-python3.7-PyMetno-0.5.0
no tests packages in pypi sdist, please fetch from github.
Tests are critical to ensuring the package isn't broken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Unfortunately there are not tests on Github either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
unfortunatley, I don't think this is a great candidate for nixpkgs (personal project, no tests), however, https://github.com/nix-community/NUR would be a good candidate if you wanted to share with others. |
Are you sure? It's used within home-assistant, which we have packaged. |
I'd be happy to submit a PR to NUR if that's the place to put it. However as @Mic92 pointed out home-assistant depends on this library to get the weather from the met.no service. Wouldn't HA be much harder to use when parts of it depend on NUR? |
I don't currently see it in nixpkgs. I would be okay with doing |
I don't quite get that. What does Should I do something like this?
|
It will essentially do |
Let's go with this solution. |
I have updated this to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rfc 45, otherwise LGTM'
[3 built, 66 copied (278.0 MiB), 60.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78132
1 package built:
python37Packages.pymetno
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Another library used by Home-Assistant. This one is for talking to the met.no service and getting the weather.
It seems the tests for
aiohttp
break when building this for python 3.8, but it works for 3.6 and 3.7.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)