Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lib: Inherit type for doRename options #78135

Merged
merged 1 commit into from Jan 20, 2020
Merged

nixos/lib: Inherit type for doRename options #78135

merged 1 commit into from Jan 20, 2020

Conversation

infinisil
Copy link
Member

Motivation for this change

#76670 with my suggestion

Ping @dasJ

Things done
  • Checked that the manual builds and displays all renamed options with their appropriate type

@dasJ @infinisil
nixos/lib: Inherit type for doRename options
790cd01 
Co-authored-by: Silvan Mosberger <contact@infinisil.com>
@infinisil infinisil merged commit 774e3d8 into NixOS:master Jan 20, 2020
@infinisil infinisil deleted the doRename-type branch January 20, 2020 22:15
@infinisil infinisil mentioned this pull request Jan 20, 2020
Closed
10 tasks
@roberth roberth mentioned this pull request Mar 18, 2020
Closed
@infinisil infinisil mentioned this pull request Mar 19, 2020
Merged
@infinisil infinisil added the 6.topic: module system About NixOS module system internals label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: module system About NixOS module system internals 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @dasJ